New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deploy Smart Contracts to Base with Cookbook.dev Documentation Section to web Repo #195
base: master
Are you sure you want to change the base?
Conversation
Thanks for taking the time to open this PR! We've added this to our backlog, pending to be reviewed. |
Hi @wbnns, can you please take a look and review this PR when you have the chance? I really appreciate it! Please let me know if you have any questions or if you'd like me to make any changes. For quick reference, here's a link to Cookbook's Base developer resources page: https://www.cookbook.dev/chains/Base Thank you. |
Thanks for the continued patience, just wanted to confirm that this is still on the radar for review. Will follow-up with any updates here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this for Base Sepolia?
![Cookbook Import Contract](../../../assets/images/deployment-with-cookbook/Import-Contract.png) | ||
|
||
:::tip | ||
Supports Base, Ethereum, Polygon, BSC, Fantom, Optimism, Arbitrum, Moonbeam, Moonriver, Gnosis and Celo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing this tip admonition. Although it's cool it supports all of these other networks, I don't think it's necessary to call out for this doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reviewing. I've updated the documentation to reference and work with Base Sepolia rather than Base Goerli. I agree with your thoughts regarding the tip and have removed it.
Review Error for taycaldwell @ 2024-01-29 18:57:47 UTC |
updated for Base Sepolia and removed tip
added missing period
What changed? Why?
This pull request introduces a new section of documentation detailing additional ways developers can quickly deploy smart contracts to Base Goerli and Base Mainnet using Cookbook.dev. The changes are based on the existing structure and format of the base-org/web repository. The primary goal of this addition is to enhance the ease at which developers can access smart contract research, development and deployment for Base.
Notes to reviewers
Followed all documentation contribution guidelines and looking forward to any feedback.
How has it been tested?
Local Testing: The documentation section has been tested locally to ensure all markdown files render correctly and the navigation between sections is smooth and intuitive.
Staging Deployment: A version of this update has been deployed to our staging environment using Vercel. This allowed us to view the documentation in a web format, ensuring that it displays correctly in a real-world setting.