Upgrade OptimismMintableERC20Factory implementation #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
33
to
39
|
|
||
| Note: there have been reports of some folks seeing this error `Error creating signer: error opening ledger: hidapi: failed to open device`. A fix is in progress, but not yet merged. If you come across this, open a new terminal and run the following to resolve the issue: | ||
| ``` | ||
| git clone git@github.com:base-org/eip712sign.git | ||
| cd eip712sign | ||
| go install | ||
| ``` |
There was a problem hiding this comment.
This is no longer relevant with the updated eip712 signer go lib.
| Make sure you are on the "Overview" tab of the tenderly simulation, to | ||
| validate integrity of the simulation, we need to check the following: | ||
|
|
||
| 1. "Network": Check the network is Optimism Mainnet. |
There was a problem hiding this comment.
Suggested change
| 1. "Network": Check the network is Optimism Mainnet. | |
| 1. "Network": Check the network is Base Mainnet. |
| '@rari-capital/solmate/=lib/solmate/', | ||
| '@base-contracts/=lib/base-contracts', | ||
| 'solady/=lib/solady/src/', | ||
| '@agora=lib/optimism-gov/src', |
Comment on lines
24
to
25
| address internal BASE_SAFE = vm.envAddress("BASE_SAFE"); | ||
| address internal OP_SAFE = vm.envAddress("OP_SAFE"); |
There was a problem hiding this comment.
These aren't needed in the script's context and can be safely removed.
wilsoncusack
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the
RunUpgradeToAndCallERC20Factoryto upgrade theOptimismMintableERC20Factoryimplementation, at address 0x4200000000000000000000000000000000000012, to point to the newly deployed factory at address 0x6922ac4DbDfEdEa3a1E5535f12c3171f2b964C91, effectively replacing the old implementation at address 0xc0D3c0d3C0d3c0d3c0D3c0d3c0D3c0D3c0D30012.