Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate resources based on template directories. #458

Draft
wants to merge 7 commits into
base: 0.3.x
Choose a base branch
from

Conversation

bartfeenstra
Copy link
Owner

This fixes #155 and #448

@bartfeenstra
Copy link
Owner Author

Site generation is significantly slower than before, possibly due to more file I/O since we first copy all files to their destination, then render the tree which, for some renderers, skips their ability to render on copy.

@bartfeenstra
Copy link
Owner Author

The problem is that this completely prevents us from adding fallback templates later, using jinja2.environment.Environment.select_template().

@bartfeenstra bartfeenstra added BC break Breaks backwards compatibility with existing integrations enhancement New feature or request labels Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 8, 2020

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (d975004) 94.66% compared to head (2004843) 93.20%.
Report is 559 commits behind head on 0.3.x.

❗ Current head 2004843 differs from pull request most recent head 1866bfe. Consider uploading reports for the commit 1866bfe to get more accurate results

Files Patch % Lines
betty/render.py 79.00% 21 Missing ⚠️
betty/fs.py 73.80% 11 Missing ⚠️
betty/sass.py 58.82% 7 Missing ⚠️
betty/jinja2.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x     #458      +/-   ##
==========================================
- Coverage   94.66%   93.20%   -1.47%     
==========================================
  Files          31       31              
  Lines        2381     2471      +90     
==========================================
+ Hits         2254     2303      +49     
- Misses        127      168      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra force-pushed the master branch 2 times, most recently from c937294 to 2675673 Compare July 12, 2021 18:50
@bartfeenstra bartfeenstra marked this pull request as draft December 23, 2023 14:39
@bartfeenstra bartfeenstra added python Pull requests that update Python code templating Jinja2 templating labels Feb 4, 2024
@bartfeenstra bartfeenstra added this to the 0.4.0 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC break Breaks backwards compatibility with existing integrations enhancement New feature or request python Pull requests that update Python code templating Jinja2 templating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split generation out per content type
1 participant