Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service containers #1378

Draft
wants to merge 1 commit into
base: 0.3.x
Choose a base branch
from
Draft

Add service containers #1378

wants to merge 1 commit into from

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Apr 6, 2024

This fixes #1373

To do

  • collect service dependencies
  • add a rebuild API and implement it for service dependencies
  • ensure full coverage for newly added code

Proposals

  • Seeing as rebuild triggering is similar to Configuration.on_update(), consider introducing an event API

@bartfeenstra bartfeenstra added enhancement New feature or request python Pull requests that update Python code labels Apr 6, 2024
Copy link

github-actions bot commented Apr 6, 2024

Uploaded Betty for commit 14177a8. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 6, 2024

Uploaded Betty for commit 18123a9. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 6, 2024

Uploaded Betty for commit cdc6fde. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/service.py Outdated Show resolved Hide resolved
betty/service.py Outdated Show resolved Hide resolved
betty/service.py Outdated Show resolved Hide resolved
betty/service.py Outdated Show resolved Hide resolved
betty/service.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 7, 2024

Uploaded Betty for commit 4082797. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 7, 2024

Uploaded Betty for commit c3187f3. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/service.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 8, 2024

Uploaded Betty for commit c46f0a3. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 9, 2024

Uploaded Betty for commit 1f9fcb7. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 9, 2024

Uploaded Betty for commit ef70ca2. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 9, 2024

Uploaded Betty for commit 11e5eb6. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 9, 2024

Uploaded Betty for commit fb8de81. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 9, 2024

Uploaded Betty for commit c6c02ff. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 98.64865% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 93.29%. Comparing base (e29a58d) to head (7e13818).

Files Patch % Lines
betty/service/__init__.py 96.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1378      +/-   ##
==========================================
+ Coverage   93.21%   93.29%   +0.08%     
==========================================
  Files          94       96       +2     
  Lines        9649     9797     +148     
==========================================
+ Hits         8994     9140     +146     
- Misses        655      657       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 9, 2024

Uploaded Betty for commit 13332e8. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 7b7ecb9. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 3fd0161. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit d1f033d. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit ed544ce. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 5b07950. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented May 7, 2024

Uploaded Betty for commit 7e13818. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 7966cf0. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service containers
1 participant