Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Configuration into dataclass #135

Merged
merged 10 commits into from Jan 16, 2024
Merged

Refactor Configuration into dataclass #135

merged 10 commits into from Jan 16, 2024

Conversation

barrust
Copy link
Owner

@barrust barrust commented Jan 9, 2024

Hide configuration, etc. in a configuration dataclass

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (5f4cfe2) 94.73% compared to head (655d8d5) 94.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   94.73%   94.79%   +0.05%     
==========================================
  Files           5        6       +1     
  Lines        1083     1210     +127     
==========================================
+ Hits         1026     1147     +121     
- Misses         57       63       +6     
Files Coverage Δ
mediawiki/__init__.py 100.00% <100.00%> (ø)
mediawiki/utilities.py 100.00% <100.00%> (ø)
mediawiki/configuraton.py 97.24% <97.24%> (ø)
mediawiki/mediawiki.py 92.54% <80.30%> (-0.77%) ⬇️

@barrust barrust merged commit 523a675 into master Jan 16, 2024
17 checks passed
@barrust barrust deleted the refactor-config branch January 16, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants