Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing support #132

Merged
merged 17 commits into from Jan 6, 2024
Merged

Add typing support #132

merged 17 commits into from Jan 6, 2024

Conversation

barrust
Copy link
Owner

@barrust barrust commented Jan 6, 2024

This PR handled several major items:

  • black and isort formatting
  • removed relative imports
  • pyupgrade --py38-plus including f-strings, etc
  • typing support
  • added python 3.12 support

The main thing is typing!

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (86c4080) 95.71% compared to head (8c383d5) 94.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   95.71%   94.81%   -0.90%     
==========================================
  Files           5        5              
  Lines        1096     1119      +23     
==========================================
+ Hits         1049     1061      +12     
- Misses         47       58      +11     
Files Coverage Δ
mediawiki/__init__.py 100.00% <100.00%> (ø)
mediawiki/exceptions.py 99.09% <100.00%> (+0.01%) ⬆️
mediawiki/utilities.py 100.00% <100.00%> (ø)
mediawiki/mediawikipage.py 94.49% <94.40%> (-1.36%) ⬇️
mediawiki/mediawiki.py 93.43% <92.52%> (-0.79%) ⬇️

@barrust barrust merged commit ef22c59 into master Jan 6, 2024
7 checks passed
@barrust barrust deleted the code-cleanup branch January 6, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants