fix(armv8-r/mem): fix shareability memory flag to allow guests decide their cacheability attributes #130
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Afonso Santos <afomms@gmail.com>
danielRep
approved these changes
May 23, 2024
josecm
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shareability attributes impact the final cacheability attributes of a memory region. On a system with a 2-stage controlled MPU, this level configuration can limit the guest's configuration of its memory region.
This way, the EL2 MPU should be permissive enough to allow the guest to decide the cacheability attributes in its memory regions.
Previously, the EL2 was configuring the guest's shareability attributes as inner shareable, which limited the shareability attributes for the EL1 to only inner shareable or outer shareable.
Changing the EL2 flag to non-shareable allows the guest to decide freely its shareability domain.