fix(core/vmm): fixe use of fences on VMM install #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First a fence was required to enforce the dependency on `install_info_ready` being set calling vmm_vm_install as there is no real data dependency. Second, we move the write fence which ensures the write to the page table is visible to within the install function. It is it responsibility to ensure it returns with its effects visible. Signed-off-by: Jose Martins <josemartins90@gmail.com>
josecm
force-pushed
the
fix/fences_vm_install
branch
from
2da121f
to
599f251
Compare
Closed
DavidMCerdeira
approved these changes
May 22, 2024
danielRep
approved these changes
May 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First a fence was required to enforce the dependency on
install_info_readybeing set calling vmm_vm_install as there is no real data dependency.Second, we move the write fence which ensures the write to the page table is visible to within the install function. It is it responsibility to ensure it returns with its effects visible.