RFC: support python 3.12 (but drop 3.8) #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2024 10:41
….8 due to scipy As of 2024-02, Python 3.8 is still going to be supproted for 6 months (until 2024-10, see https://devguide.python.org/versions). At the same time, Python 3.12 was released four months ago, on 2023-10, and will be supported for five years. We cannot support both, because scipy 1.10 does not work with python 3.12, and scipy 1,11 drops python 3.8. Having to make a choiche, it is probably better to go with the more recent versions, thus 3.8 has to go down the drain.
Maybe there are wiser ways of only requiring updated packages for python 3.12, while still allowing older package versions for python <= 3.11, but I was only looking for the minimum set of working packages. The issue with numpy is documented here, and officially solved with numpy 1.26: https://numpy.org/devdocs/reference/distutils_status_migration.html This commit needs to be reworked, and either squashed in the one updating the python compatibility, or better moved BEFORE dropping python 3.8 and introducing 3.12.
muxator
force-pushed
the
support-3.12
branch
from
a78e3ad
to
af1b6dd
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 89.22% 88.83% -0.40%
==========================================
Files 42 42
Lines 1782 1791 +9
==========================================
+ Hits 1590 1591 +1
- Misses 192 200 +8
|
muxator
force-pushed
the
support-3.12
branch
from
af1b6dd
to
dc4694c
Compare
muxator
force-pushed
the
support-3.12
branch
from
156f5d2
to
554a754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment aimed at supporting python 3.12, which is already at its second point release.
Formally, python 3.8 is still going to be supported for 6 months (https://devguide.python.org/versions). However, some packages have already dropped it.
In particular, there is no scipy version supporting 3.8 and 3.12 at the same time, and this forces us to make a choice.
After bumping scipy to >= 1.11, poetry is able to resolve the dependencies.
At install time there were 2 more problems:
numpydid not install because python 3.12 dropped support for distutils (https://peps.python.org/pep-0632/). There are workarounds for this (https://numpy.org/devdocs/reference/distutils_status_migration.html), but bumping to 1.26 seems to be an official solutionstatsmodels0.13 did not compile under python 3.12, probably because it is compiled with-Werror, and there are some deprecation warnings when compiling its wheel. Bumping to 0.14 solved the issue.This is just the easiest set of actions for allowing the project to run on python3.12. There might be ways to keep a more relaxed set of dependencies (for example, only install numpy 1.26 under python 3.12) if we want to be more permissive.
Local tests on my Fedora with python 3.12 completed fine. Opening the PR to see what the CI (and the fellow devs) think about it.