Added perPage parameter to targets.get_assets()

bamhm182 · Apr 16, 2023 · 9a5a2aa · 9a5a2aa
1 parent f6ab276
commit 9a5a2aa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/synack/plugins/targets.py b/src/synack/plugins/targets.py
@@ -103,7 +103,7 @@ def get_assessments(self):
 
     def get_assets(self, target=None, asset_type=None, host_type=None, active='true',
                    scope=['in', 'discovered'], sort='location', sort_dir='asc',
-                   page=None, organization_uid=None, **kwargs):
+                   page=1, perPage=500, organization_uid=None, **kwargs):
         """Get the assets (scope) of a target"""
         if target is None:
             if len(kwargs) > 0:
@@ -137,6 +137,8 @@ def get_assets(self, target=None, asset_type=None, host_type=None, active='true'
                 queries.append(f'sortDir={sort_dir}')
             if page is not None:
                 queries.append(f'page={page}')
+            if perPage is not None:
+                queries.append(f'perPage={perPage}')
 
             res = self.api.request('GET', f'asset/v2/assets?{"&".join(queries)}')
             if res.status_code == 200:

diff --git a/test/test_targets.py b/test/test_targets.py
@@ -228,7 +228,7 @@ def test_get_assets(self):
         self.targets.api.request.assert_called_with('GET',
                                                     'asset/v2/assets?listingUid%5B%5D=327h8iw&scope%5B%5D=in' +
                                                     '&scope%5B%5D=discovered&sort%5B%5D=location&active=true' +
-                                                    '&sortDir=asc')
+                                                    '&sortDir=asc&page=1&perPage=500')
 
     def test_get_assets_non_defaults(self):
         """Should return a list of assets given information to query"""
@@ -238,18 +238,19 @@ def test_get_assets_non_defaults(self):
         self.targets.api.request.return_value.json.return_value = 'retjson'
         self.assertEqual('retjson', self.targets.get_assets(codename='TURBULENTTORTOISE',
                                                             asset_type='blah',
-                                                            host_type='applecidr',
+                                                            host_type='cidr',
                                                             active='false',
                                                             scope='secret',
-                                                            sort='vulnerable',
+                                                            sort='loc',
                                                             sort_dir='desc',
                                                             page=3,
+                                                            perPage=5000,
                                                             organization_uid='uiehqw'))
         self.targets.api.request.assert_called_with('GET',
                                                     'asset/v2/assets?listingUid%5B%5D=327h8iw' +
                                                     '&organizationUid%5B%5D=uiehqw&assetType%5B%5D=blah' +
-                                                    '&hostType%5B%5D=applecidr&scope%5B%5D=secret' +
-                                                    '&sort%5B%5D=vulnerable&active=false&sortDir=desc&page=3')
+                                                    '&hostType%5B%5D=cidr&scope%5B%5D=secret' +
+                                                    '&sort%5B%5D=loc&active=false&sortDir=desc&page=3&perPage=5000')
 
     def test_get_attachments_current(self):
         """Should return a list of attachments based on currently selected target"""