Skip to content

Commit

Permalink
Use python -m pip install -U pip on Windows
Browse files Browse the repository at this point in the history
Don't run `pip install --upgrade pip` on Windows, it started to fail in
our Jenkins node and this is not the right command.

https://jira.mesosphere.com/browse/DCOS_OSS-2332
https://pip.pypa.io/en/stable/installing/#upgrading-pip
pypa/pip#1299
  • Loading branch information
bamarni committed Apr 4, 2018
1 parent 225222c commit 26dfff1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion bin/env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,11 @@ if [ ! -d "${BUILDDIR}/${VENV}" ]; then

# Install all requirements into the virtualenv.
echo "Installing virtualenv requirements..."
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install --upgrade pip
if [ "$(uname)" = "Windows_NT" ]; then
${PYTHON} -m pip install -U pip
else
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install --upgrade pip
fi
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install -r ${BASEDIR}/requirements.txt
${BUILDDIR}/${VENV}/${BIN}/pip${EXE} install -e ${BASEDIR}
if [ "$(uname)" = "Windows_NT" ]; then
Expand Down

0 comments on commit 26dfff1

Please sign in to comment.