Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Allow not having source code for projects with build tools #42730

Conversation

gayaldassanayake
Copy link
Contributor

Purpose

$ subject

master PR of #42597
Fixes #42583

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@gayaldassanayake gayaldassanayake force-pushed the allow-empty-proj-for-tools-master branch from 664e293 to bdf0210 Compare May 10, 2024 10:37
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.25%. Comparing base (523fb9c) to head (bdf0210).
Report is 6 commits behind head on master.

Files Patch % Lines
...c/main/java/io/ballerina/cli/task/CompileTask.java 25.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #42730      +/-   ##
============================================
+ Coverage     77.18%   77.25%   +0.06%     
- Complexity    51274    51298      +24     
============================================
  Files          2929     2929              
  Lines        204324   204392      +68     
  Branches      26652    26660       +8     
============================================
+ Hits         157698   157893     +195     
+ Misses        38074    37919     -155     
- Partials       8552     8580      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gayaldassanayake gayaldassanayake merged commit 9c45823 into ballerina-platform:master May 15, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]: Allow the package build for empty projects when there are code generator tools
2 participants