Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Step Extension] Fix parsing of xml step extension #42722

Open
wants to merge 2 commits into
base: xml_step_extension
Choose a base branch
from

Conversation

poorna2152
Copy link
Contributor

@poorna2152 poorna2152 commented May 9, 2024

Purpose

Update parsing of xml step extension to match the spec.
https://ballerina.io/spec/lang/master/#xml-step-extend

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@poorna2152 poorna2152 force-pushed the xml_step_parsing branch 2 times, most recently from e23049d to 0d2e2ce Compare May 9, 2024 11:38
@poorna2152 poorna2152 added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label May 9, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 66.51584% with 74 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (xml_step_extension@ee7799b). Click here to learn what that means.

Files Patch % Lines
...piler/syntax/tree/XMLStepMethodCallExtendNode.java 25.00% 18 Missing ⚠️
...o/ballerina/compiler/syntax/tree/TreeModifier.java 0.00% 14 Missing ⚠️
.../compiler/internal/parser/tree/STTreeModifier.java 0.00% 8 Missing ⚠️
...ternal/parser/tree/STXMLStepIndexedExtendNode.java 58.82% 7 Missing ⚠️
...nal/parser/tree/STXMLStepMethodCallExtendNode.java 56.25% 7 Missing ⚠️
...io/ballerina/compiler/syntax/tree/NodeFactory.java 64.70% 6 Missing ⚠️
...a/compiler/internal/parser/tree/STNodeVisitor.java 0.00% 4 Missing ⚠️
...inalang/formatter/core/FormattingTreeModifier.java 76.47% 4 Missing ⚠️
...mpiler/internal/parser/tree/STNodeTransformer.java 0.00% 2 Missing ⚠️
...allerina/compiler/syntax/tree/NodeTransformer.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@                  Coverage Diff                  @@
##             xml_step_extension   #42722   +/-   ##
=====================================================
  Coverage                      ?   77.13%           
  Complexity                    ?    51242           
=====================================================
  Files                         ?     2928           
  Lines                         ?   204207           
  Branches                      ?    26628           
=====================================================
  Hits                          ?   157518           
  Misses                        ?    38176           
  Partials                      ?     8513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant