Warn about corruption in Dependencies.toml. #42717
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thevakumar-Luheerathan
requested review from
hevayo,
sameerajayasoma and
hasithaa
as code owners
| new CommandLine(buildCommand); | ||
| buildCommand.execute(); | ||
| String buildLog = readOutput(true); | ||
| Assert.assertTrue(buildLog.contains("WARNING [Dependencies.toml:(6:1,18:1)] " + |
There was a problem hiding this comment.
Can we check for an exact match here with the expected log written in a file? AFAIR we did this for most of the existing tests.
| if (parsedDependecyManifest.diagnostics().hasErrors()) { | ||
| var diagnosticInfo = new DiagnosticInfo( | ||
| ProjectDiagnosticErrorCode.CORRUPTED_DEPENDENCIES_TOML.diagnosticId(), | ||
| "Detected corrupted 'Dependencies.toml' file. This will be updated to latest dependencies.", |
There was a problem hiding this comment.
Suggested change
| "Detected corrupted 'Dependencies.toml' file. This will be updated to latest dependencies.", | |
| "Detected corrupted 'Dependencies.toml' file. This will be updated to the latest dependencies.", |
also IMO, it's better to say something like,
Detected corrupted 'Dependencies.toml' file. Dependencies will be updated to the latest versions ignoring the 'Dependencies.toml'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #42106
Approach
Samples
Remarks
Check List