New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Fix file too large due to many record default functions #42671
base: master
Are you sure you want to change the base?
[master] Fix file too large due to many record default functions #42671
Conversation
ec0b0bf
to
7e546dc
Compare
bfb1258
to
da8d418
Compare
da8d418
to
3064e43
Compare
...r/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmConstants.java
Outdated
Show resolved
Hide resolved
...er/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmValueGen.java
Outdated
Show resolved
Hide resolved
...va/org/wso2/ballerinalang/compiler/bir/codegen/internal/RecordDefaultValueDataCollector.java
Outdated
Show resolved
Hide resolved
...rina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/methodgen/LambdaGen.java
Show resolved
Hide resolved
9f16942
to
6fff3b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #42671 +/- ##
=========================================
Coverage 77.26% 77.27%
- Complexity 51301 51315 +14
=========================================
Files 2928 2932 +4
Lines 204391 204470 +79
Branches 26659 26677 +18
=========================================
+ Hits 157925 158001 +76
+ Misses 37885 37882 -3
- Partials 8581 8587 +6 ☔ View full report in Codecov by Sentry. |
...ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmCodeGenUtil.java
Outdated
Show resolved
Hide resolved
|
||
if (!isSamePkg) { | ||
mv.visitLdcInsn(lambdaDetails.encodedFuncName); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (!isSamePkg) { | |
mv.visitLdcInsn(lambdaDetails.encodedFuncName); | |
} | |
if (!isSamePkg) { | |
mv.visitLdcInsn(lambdaDetails.encodedFuncName); | |
} |
Purpose
Fixes #42655
Approach
This PR will improve the generated to code as below to avoid file too large and method too large issues due to high record default functions.
Check List