[2201.8.x] Revise the definition API of the TypeReferenceTypeSymbol to exclude searching for virtual symbols in the scope
#42626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunayf
added
the
Team/CompilerFE
| @@ -103,7 +104,7 @@ public Symbol definition() { | |||
| if (referredType.tag == TypeTags.PARAMETERIZED_TYPE || bType.tag == TypeTags.PARAMETERIZED_TYPE) { | |||
| this.definition = symbolFactory.getBCompiledSymbol(((BParameterizedType) this.tSymbol.type).paramSymbol, | |||
| this.name()); | |||
| } else if (referredType.tag == TypeTags.INTERSECTION) { | |||
| } else if (referredType.tag == TypeTags.INTERSECTION || referredType.tsymbol.origin == SymbolOrigin.VIRTUAL) { | |||
There was a problem hiding this comment.
Instead of this approach, can't we check whether readonly flag is set or not?
There was a problem hiding this comment.
It is not clear at which position I should make your change. If you are suggesting replacing the virtual check with readonly, then it breaks the existing cases.
For instance, in the following case, the definition is correct as we are looking for the symbol through its name. However, with the mentioned change, it would use the tsymbol instead as the symbol is readonly, which will produce an incorrect type definition symbol.
type Student string;
function fn() {
Student student = "A";
}
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$title as virtual symbols are not stored in the scope.
Fixes #42454
Approach
The current approach ensures that the
definitionAPI of the type references does not search for virtual symbols in the current scope.Remarks
Although this PR fixed the semantic API issue, the tsymbol set for narrowed type symbols remains invalid, which is being tracked separately.
Check List