Integrate function semtype into jBallerina type engine #42622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make Env part of the type * Make modification of param type list explicit
heshanpadmasiri
force-pushed
the
feat/semtype-fn
branch
2 times, most recently
from
8f507dd
to
e8ae63a
Compare
heshanpadmasiri
force-pushed
the
feat/semtype-fn
branch
2 times, most recently
from
586c49d
to
5c5e48d
Compare
When we have a cyclic intersection we first create the member types then create the intersection type. Only after this we fill in the member types, and we have no way of detecting this has happen and reset the semtype calculation.
heshanpadmasiri
force-pushed
the
feat/semtype-fn
branch
from
5c5e48d
to
95bee5d
Compare
heshanpadmasiri
commented
May 7, 2024
| @@ -59,6 +59,15 @@ private static boolean functionPathIsEmpty(Context cx, SemType params, Conjuncti | |||
| FunctionAtomicType t = cx.functionAtomType(neg.atom); | |||
| SemType t0 = t.paramType(); | |||
| SemType t1 = t.retType(); | |||
| if (t.isGeneric()) { | |||
| // TODO: this is not correct. Ideally we should either resolve generic function calls to concrete | |||
There was a problem hiding this comment.
Created #42700 to track this
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Depends on #42511
Fixes #42512
Approach
Samples
Remarks
Check List