Fix compiler crash on xml attribute access on non xml:Element values
#42598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorna2152
added
the
Team/CompilerFE
poorna2152
force-pushed
the
xml_attr_crash
branch
from
4ae3140
to
58b2967
Compare
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
| @@ -8619,6 +8619,9 @@ private BType getLaxFieldAccessType(BType exprType) { | |||
| return symTable.jsonType; | |||
| case TypeTags.XML: | |||
| case TypeTags.XML_ELEMENT: | |||
| case TypeTags.XML_COMMENT: | |||
There was a problem hiding this comment.
My concern is why we include XML within the getLaxFieldAccessType function. If the type is lax, then the lax field access rules are included. XML is not a lax type, correct?
| @@ -314,7 +314,7 @@ public BType checkType(Location pos, | |||
| public boolean isLaxFieldAccessAllowed(BType type) { | |||
| type = Types.getImpliedType(type); | |||
| Set<BType> visited = new HashSet<>(); | |||
| return isLaxType(type, visited) == 1 || type.tag == TypeTags.XML || type.tag == TypeTags.XML_ELEMENT; | |||
| return isLaxType(type, visited) == 1 || isAssignable(type, symTable.xmlType); | |||
There was a problem hiding this comment.
In the previous implementation, this was also incorrect. Lax field access should only be allowed for lax types. However, XML is not a lax type. I have concerns about including this logic within this function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #35191
Approach
Fix xml attribute access on all subtypes of xml
Samples
Remarks
Check List