Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add style guideline for const-decl best practices #8884

Merged
merged 4 commits into from May 3, 2024
Merged

Add style guideline for const-decl best practices #8884

merged 4 commits into from May 3, 2024

Conversation

lochana-chathura
Copy link
Member

Purpose

$subject.

Fixes #8608

Checklist

  • Page addition

    • Add permalink to pages.

  • Page removal

    • Remove entry from corresponding left nav YAML file.
    • Add redirect_from on the alternative page.
    • If no alternative page, add redirection on the redirections.js file.

  • Page rename

    • Add front-matter redirect_from.
    • Add front-matter redirect_to: (if applicable).

  • Page restrcuture

    • Add permalink to pages.
    • Add front-matter redirect_from.
    • Add front-matter redirect_to: (if applicable).

prakanth97
prakanth97 previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@prakanth97 prakanth97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nipunayf nipunayf mentioned this pull request Apr 24, 2024
Open
@nipunayf nipunayf mentioned this pull request Apr 26, 2024
Open
13 tasks
@lochana-chathura @MaryamZi
Apply suggestions from code review
0c2ed78 
Co-authored-by: Maryam Ziyad <maryamziyadm@gmail.com>
@sm1990 sm1990 merged commit 1bd1b0a into ballerina-platform:master May 3, 2024
1 check passed
@lochana-chathura lochana-chathura deleted the add-const-guide branch May 7, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sm1990 sm1990 sm1990 approved these changes

@MaryamZi MaryamZi MaryamZi approved these changes

@prakanth97 prakanth97 prakanth97 approved these changes

@nipunayf nipunayf nipunayf approved these changes

@praneesha praneesha Awaiting requested review from praneesha praneesha is a code owner

@LakshanWeerasinghe LakshanWeerasinghe Awaiting requested review from LakshanWeerasinghe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a subsection under the top level definition in style guides to specify constant declaration best practices
5 participants
@lochana-chathura @sm1990 @MaryamZi @prakanth97 @nipunayf