Add frontend implementation for Reviewed! #2
Conversation
Xenowa
force-pushed
the
session-3-frontend
branch
from
f27628f
to
2254515
Compare
Xenowa
force-pushed
the
session-3-frontend
branch
2 times, most recently
from
736e87f
to
f7caead
Compare
session-3/frontend/README.md
Outdated
| 4. Open the browser and navigate to [http://localhost:3000](http://localhost:3000). | ||
|
|
||
| 5. For deploying the application, create a production build by running the following command. |
There was a problem hiding this comment.
Shouldn't these be swapped?
There was a problem hiding this comment.
Since this section is in the context of a user who is running the front-end in dev mode, deployment was mentioned as the last point. The reason is that during development, the changes made in the JavaScript files of the React code will be instantly visible on the served URL. However if the user has created a production build and is serving it instead, the changes made on the JavaScript files won't be visible on the served files.
|
|
||
| ```bash | ||
| npm run build | ||
| ``` |
There was a problem hiding this comment.
Eventually, I think we can elaborate a bit on the underlying implementation. E.g., we can a screenshot of each page, mention the GraphQL query, any additional processing we do on the response, etc.
There was a problem hiding this comment.
Not required for this first iteration.
Xenowa
force-pushed
the
session-3-frontend
branch
3 times, most recently
from
f3e5bf8
to
9577def
Compare
Purpose