[1.X] Do not remove the supervisor container before every start #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarranzav
force-pushed
the
184-1.X-dont-rm-supervisor
branch
from
24c541e
to
1f01ca8
Compare
added 2 commits
February 1, 2017 13:16
…in every start We add a start-resin-supervisor script that checks whether the existing container's image matches the one specified in supervisor.conf, and just starts that container in that case. It falls back to the docker run command that creates and starts the supervisor container. Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
…update script Also, only write /tmp/supervisor.conf after the image has been successfully pulled and the old container has been removed. Signed-off-by: Pablo Carranza Velez <pablo@resin.io>
agherzan
force-pushed
the
184-1.X-dont-rm-supervisor
branch
from
1f01ca8
to
5aadbb1
Compare
agherzan
approved these changes
Feb 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, we add a start-resin-supervisor script that checks
whether the existing container's image matches the one specified
in supervisor.conf, and just starts that container in that case.
It falls back to the docker run command that creates and starts
the supervisor container.
We also add the container removal in the update-resin-supervisor script,
after stopping the resin-supervisor service.
Connects to #184
Also connects to #280 as it should make the issue appear way less often.