Update overall status computed field

[JSReds]

Change-type: minor

See: https://balena.zulipchat.com/#narrow/stream/346007-balena-io.2FbalenaCloud/topic/Server.20side.20device.20list.20-.20cycle.202
See: https://balena.fibery.io/favorites/Work/Project/414

[thgreasi]

Should we also drop these non-used & already dropped HoD states, rather re-adding them?

[thgreasi]

How about v so that vpn disabled&off & heartbeat timeout gives reduced-functionality?

-- In an ideal world:
partial = CASE
	WHEN vpn disabled
	THEN heartbeat = timeout
	ELSE (vpn on & heartbeat != online) || (vpn off & heartbeat = online,timeout)

=>

partial = CASE
	WHEN heartbeat = timeout THEN True
	ELSE (vpn enabled && vpn on & heartbeat IN offline)
		|| (vpn off & heartbeat = online && vpn enabled)

approximately => (so that we push `vpn enabled` later and reduce the cases that it needs to be checked)

partial = CASE
	WHEN heartbeat = timeout THEN True
	ELSE (vpn on & heartbeat IN offline)
		|| (vpn off & heartbeat = online && vpn enabled)

=>

partial =
	|| heartbeat = timeout
	|| (vpn on & heartbeat IN offline/unknown)
	|| (vpn off & heartbeat = online && vpn enabled)

=>

partial =
	|| heartbeat = timeout
	|| (vpn on & heartbeat != online)
	|| (vpn off & heartbeat = online && vpn enabled)

[thgreasi]

How about?

Suggested change

	const VPNConfigEnabled: NotEqualsNode = [
	const isVpnEnabled: NotEqualsNode = [

[thgreasi]

Not a blocker: Should we add the same check in the overall_progress (and add a v6 translation)?
I kind of can see the use case of showing a progress bar in a reduced-functionality device... so just checking whether this was discussed.

We would effectively just need to change

			[
				'When',
				[
						'NotIn',
						['ReferencedField', 'device', 'api heartbeat state'],
						['EmbeddedText', 'online'],
						['EmbeddedText', 'timeout'],
				],
				// Otherwise if the device is offline but has previously been online we return no info
				['Null'],
			],

to

			[
				'When',
				isOverallOffline,
				// Otherwise if the device is offline but has previously been online we return no info
				['Null'],
			],

Not a blocker though, since we can change it later.

[thgreasi]

Lets also change the commit message to something that makes clear that this only about /resin and doesn't affect v6
"Update the overall_status computed field in the unversioned model" or
"Update the overall_status computed field in the resin model" or
"Update the overall_status computed field for the future v7 model"

[thgreasi]

Suggested change

	it(`should have "${overallStatus}" ${restTitle}`, async () => {
	it(`should have overall_status = "${overallStatus}" ${restTitle}`, async () => {

or

Suggested change

	it(`should have "${overallStatus}" ${restTitle}`, async () => {
	it(`should have an overall_status of "${overallStatus}" ${restTitle}`, async () => {