Draft: Replace request with axios
#1466
Draft
+132
−629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Have you looked at https://github.com/sindresorhus/got/blob/main/documentation/tips.md#proxying ?
|
@Page- Currently we won't be able to natively use 'got' sindresorhus/got#1789 as |
Drop in replacement for `request` with `got` is not possible, as `got` no proxy support has. `Axios` comes with proxy support and similar size of package as `got`. Change-type: major Signed-off-by: Harald Fischer <harald@balena.io> Signed-off-by: fisehara <harald@balena.io>
fisehara
force-pushed
the
fisehara/replace-request-with-axios
branch
from
969ff30
to
918afdd
Compare
|
Would it be better to wait until we can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop in replacement for
requestwithgotis not possible, asgotno proxy support has.Axioscomes with proxy support and similar size of package asgot.Axioshas no proxy+tunnel support and needstunnelas HttpAgent. With this limitations,gotcould also be used.Change-type: major