Send registry image pulls metrics to prometheus #1238
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch
otaviojacobi
force-pushed
the
send-registry-pulls-prometheus
branch
from
5da6a48
to
d06ab34
Compare
Page-
reviewed
Feb 2, 2023
|
|
||
| export function incrementRegistryImagePulls( | ||
| value: number = 1, | ||
| payload: any = {}, |
There was a problem hiding this comment.
Can you type this better than any please
| ); | ||
|
|
||
| export function incrementRegistryImagePulls( | ||
| value: number = 1, |
There was a problem hiding this comment.
When you specify a default value then the type defaults to the type of that default value:
Suggested change
| value: number = 1, | |
| value = 1, |
There's nothing wrong with explicitly specifying number but it's redundant and makes sense imo to reserve for only the cases where you want a type that is different to that of the default value
| @@ -591,6 +592,17 @@ export const token: RequestHandler = async (req, res) => { | |||
| authorizeRequest(req, scopes, tx), | |||
| ]), | |||
| ); | |||
|
|
|||
| access.forEach((ac) => | |||
| incrementRegistryImagePulls(1, { | |||
There was a problem hiding this comment.
I would name the metric differently to show that it is images that have had a token validated for access rather than image pulls (you can use the image to pull 0 or 2+ times as well so it's not 1-1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch