Upgrade dockerode and docker-modem dependencies #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Page-
reviewed
Apr 16, 2024
kb2ma
force-pushed
the
upgrade_dockerode
branch
from
dbd9219
to
651fe61
Compare
|
Rebased, simplified tests, and one more dedupe. Let me know if I need to squash the simplification. Otherwise should be ready to go @Page- . |
Includes test fixes due to an interface change in docker-modem. Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
Signed-off-by: Ken Bannister <kb2ma@runbox.com>
kb2ma
force-pushed
the
upgrade_dockerode
branch
from
651fe61
to
55d06ac
Compare
|
@otaviojacobi , I'd appreciate one more set of eyes on this update. |
otaviojacobi
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to apocas/dockerode#751, the major version bumps to dockerode and docker-modem were due to a mistake in code that was merged. So there is not a significant change to functionality. However, this PR does include test fixes due to an interface change in docker-modem.
Froze @types/dockerode dependency at v3.3.23 due to incompatibility with changes in v3.3.26. DefinitelyTyped/DefinitelyTyped#68935 adds specification of ImageTagOptions. However, they do not include some options used by balenaCLI. This incompatibility should be addressed in that repo.