Allow most printable ASCII chars for object label key (b-cli) #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ResinCI/npm/linux-ubuntu-x86_64-node14 check fails 2 tests, both due to timeout failures > 12000 ms. However, my local tests pass on node 12 and node14. Notice time to run tests below is < 1000 ms in both cases. |
|
@balena-ci retest |
kb2ma
changed the title
ab77
force-pushed
the
update_compose_label_chars
branch
from
fa303c0
to
975df40
Compare
ab77
force-pushed
the
update_compose_label_chars
branch
from
975df40
to
b843d20
Compare
Implemented as a balena-compose dependency update. Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
kb2ma
force-pushed
the
update_compose_label_chars
branch
from
b843d20
to
2782347
Compare
|
Removed pinning dockerode to v3.3.3. That has been done in #2599 . Still waiting for merge of balena-io-modules/balena-compose#13 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented as a balena-compose dependency update. See balena-io-modules/balena-compose#13 . Extends acceptable label characters to printable ASCII characters except space, single/double quotes and backtick.
Draft PR until balena-compose PR merged so uses the generated version number.
As of 2023-03-22 this PR still is blocked on an overall system solution between clients and server. This PR is useful; however older clients likely will fail in some way if they receive a service containing the extra characters.
Updates
npm-shrinkwrap.jsonMajor
@types/ssh2 0.5.52 --> 1.11.6, which removed its unnecessary dependency on ssh2-streams. See DefinitelyTyped/DefinitelyTyped#60982 , from 2022-06.
Minor
Patch