Fixed Test Character testing #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisys
reviewed
Jun 14, 2021
| if FONT_SIZE <= 17: | ||
| FONT_SIZE = 8 | ||
| if FONT_SIZE <= 12: | ||
| FONT_SIZE = 10 |
There was a problem hiding this comment.
I've been testing and I think here you might be making changes specific to the Waveshare display, the pixel font in size 10 on the InkyPHAT isn't readable at all, and the same goes for allowing the selected font to go down to 12, probably because the display is a slightly different resolution. I'd be happy to merge the optimisations but we'll need to make them specific to that display when it comes to sizes. We could also consider default values specific to the display type, but user-configurable too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out changes as requested by @chrisys #51