ProtocolFeeSplitter factory default #2133
Open
+290
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nue share; add overrideSet to RevenueShareSettings
EndymionJkb
changed the title
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSplitter.sol # pkg/standalone-utils/contracts/ProtocolFeeSplitter.sol # pkg/standalone-utils/test/ProtocolFeeSplitter.test.ts
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSplitter.sol # pkg/standalone-utils/contracts/ProtocolFeeSplitter.sol
# Conflicts: # pkg/interfaces/contracts/standalone-utils/IProtocolFeeSplitter.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow setting a default revenue share per factory, in addition to per pool. Since pool types are very different, so a single default revenue share is not the best solution. Having defaults per factory avoids having to set overrides on every single pool.
The logic is then straightforward. If there is an override share percentage set on a pool, it will use that. Otherwise, if there are factory defaults and the pool was deployed from one of them, use the factory default. Otherwise, fall back on the "global" default revenue share.
This PR is based from the "sentinel" PR (#2131), as it extends this logic.
Type of change
Checklist:
master, or there's a description of how to mergeIssue Resolution
Resolves #2050