[WIP] Use relayer balance for exits in vault actions (BPT in). #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
reviewed
Sep 16, 2022
| } else { | ||
| // Save gas by only re-encoding the data if we actually performed a replacement | ||
| return userData; | ||
| } | ||
| } | ||
|
|
||
| function _useRelayerBalance(uint256 bptAmountIn) internal pure returns (bool) { | ||
| // Look for 0xa11 sentinel value to use all of relayer's balance. |
There was a problem hiding this comment.
Lol does this stand for 'all'? 😂
There was a problem hiding this comment.
if 0xba1 stands for BAL, why not? 🙃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #945.
This initial draft replaces BPT amount in for the relayer balance when a sentinel value (
0xa11) is found in the amount.Some notes:
else ifwhen we look for chained references as in this draft.Input is welcome!