osc133: initial patch implementation #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshVerma
commented
Mar 18, 2024
| @@ -0,0 +1,23 @@ | |||
| void scrolltoprompt(const Arg *arg) { | |||
There was a problem hiding this comment.
This function implicitly depends on other patches and I need help in placing macro guards here as I'm not yet familiar with st's internals.
UtkarshVerma
force-pushed
the
osc133-patch
branch
from
0be238e
to
8d878a3
Compare
veltza
reviewed
Mar 18, 2024
UtkarshVerma
force-pushed
the
osc133-patch
branch
from
8d878a3
to
e2ce96c
Compare
|
I'm wondering if the OSC 133 should be a core feature since it doesn't do anything by itself. Only certain patches such as the scrollback and externalpipe can take advantage of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces support for OSC133 as discussed in #126. It borrows veltza's st-sx implementation and introduces two new key bindings,
<ctrl+shift+z/x>to scroll between prompts.