Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.7] Intermedium Between #115

Merged
merged 1 commit into from
Apr 19, 2021
Merged

[0.7] Intermedium Between #115

merged 1 commit into from
Apr 19, 2021

Conversation

kaioken
Copy link
Member

@kaioken kaioken commented Apr 14, 2021

While opendistro sql driver adds support for the BETWEEN lexico , we will have to implement a patch to use >= <=
opendistro-for-elasticsearch/sql#1067

@todo
Copy link

todo bot commented Apr 14, 2021

add findFirst and Find() like phalcon

* @todo add findFirst and Find() like phalcon
*
* @param string $sql
*
* @return array


This comment was generated by todo based on a todo comment in 010eca9 in #115. cc @bakaphp.

@todo
Copy link

todo bot commented Apr 14, 2021

temp solution to handle between while this pull is merged opendistro-for-elasticsearch/sql#1067

* @todo temp solution to handle between while this pull is merged https://github.com/opendistro-for-elasticsearch/sql/pull/1067
*/
$comparison .= $operator == '>' ? ' AND ' . $field . ' <= ' . $value : ' OR ' . self::buildComparison($field, $operator, $value);
//$comparison .= $operator == 'BETWEEN' ? ' AND ' . $value : ' OR ' . self::buildComparison($field, $operator, $value);
}


This comment was generated by todo based on a todo comment in 010eca9 in #115. cc @bakaphp.

@kaioken kaioken requested review from dasdo and FredPeal April 14, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants