raft learner support. #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yichao Li <liyichao.good@gmail.com>
CkTD
reviewed
Dec 14, 2023
| @@ -1609,7 +1625,7 @@ void NodeImpl::pre_vote(std::unique_lock<raft_mutex_t>* lck, bool triggered) { | |||
|
|
|||
| for (std::set<PeerId>::const_iterator | |||
| iter = peers.begin(); iter != peers.end(); ++iter) { | |||
| if (*iter == _server_id) { | |||
There was a problem hiding this comment.
计算 last_leader_active_timestamp、check_dead_nodes、check_majority_nodes_readonly 的时候也应该过滤掉 learner 吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
learner will neither participate in elections nor be inclued in quorum, and will not trigger election_timeout or vote.
This feature makes it easy to add a read-only replica to server, only making minimum influence to the raft group. It is also useful for replication between clusters at different data center.