Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot client to v7 (v7.0.0) #1258

Merged

Conversation

tesshuflower
Copy link
Contributor

Describe what this PR does

Is there anything that requires special attention?

Related issues:

Signed-off-by: Tesshu Flower <tflower@redhat.com>
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.3%. Comparing base (cfc85a4) to head (820c4aa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1258     +/-   ##
=======================================
- Coverage   67.4%   67.3%   -0.2%     
=======================================
  Files         57      57             
  Lines       5805    5805             
=======================================
- Hits        3918    3912      -6     
- Misses      1602    1605      +3     
- Partials     285     288      +3     
Files Coverage Δ
controllers/mover/rclone/mover.go 74.2% <ø> (ø)
controllers/mover/restic/mover.go 82.4% <ø> (ø)
controllers/mover/rsync/mover.go 77.8% <ø> (ø)
controllers/mover/rsynctls/mover.go 74.1% <ø> (ø)
controllers/replicationdestination_controller.go 82.4% <ø> (ø)
controllers/replicationsource_controller.go 66.8% <ø> (ø)
controllers/utils/cleanup.go 56.1% <ø> (ø)
controllers/volumehandler/volumehandler.go 56.1% <ø> (ø)
controllers/volumepopulator_controller.go 72.6% <ø> (-1.3%) ⬇️

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

@openshift-ci openshift-ci bot requested a review from JohnStrunk May 10, 2024 16:59
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tesshuflower
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7d130f4 into backube:main May 13, 2024
29 checks passed
@tesshuflower tesshuflower deleted the external-snapshotter-v7 branch May 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants