Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl volsync rsync tls #1238

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tesshuflower
Copy link
Contributor

Describe what this PR does

  • Implements kubectl-volsync migration and replication for rsync-tls.

Migration for rsync-tls will require having stunnel installed locally.

  • Also has a fix for migration to set the default replicationdestination name to something shorter, and allow optionally passing in the rdname as a parameter.

Is there anything that requires special attention?

  • Versioned the data structure to v2 to try to keep all params saved in the data structure identical for rsync and rsync-tls and have an option for rsync-tls enabled
  • rsynctls is currently defaulted to false
  • When loading v1, automatically convert it to v2 and proceed.
  • it's a bit messy with all the new parameters, hopefully not too confusing.
  • implemented an rsync and rsync-tls version of handlers in an attempt to separate them - will make it easier to remove rsync too if we ever get to that point.
  • Testing particularly on the cli migration side isn't great, but at least was able to add new e2e tests for cli replication.

Related issues:
#369
#1075

- Also add --rdname cli flag

Fixes: backube#1075

Signed-off-by: Tesshu Flower <tflower@redhat.com>
Signed-off-by: Tesshu Flower <tflower@redhat.com>
Signed-off-by: Tesshu Flower <tflower@redhat.com>
Signed-off-by: Tesshu Flower <tflower@redhat.com>
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Apr 29, 2024

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.6% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant