Layout Equivalence. #101
Open
Layout Equivalence. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersio
force-pushed
the
anders/layout-compatibility
branch
3 times, most recently
from
79b53f6
to
6e13b43
Compare
andersio
force-pushed
the
anders/layout-compatibility
branch
from
6e13b43
to
4e5379e
Compare
sergdort
reviewed
Feb 4, 2019
sergdort
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As established in #80, the ultimate goal of Bento is to enable size caching by default, while minimising the performance hit for screens with high frequency changes (e.g. forms).
To achieve the latter, Bento needs to determine whether component instances result in equivalent layouts, and in turn avoid having to invalidate any cached layout information whose re-computation might take one or two order of magnitude longer in time.
This PR introduces a mean for the components to provide a definition of layout equivalence, as an optional
Renderable.layoutEquivalence(_:_:)requirement.WIP: Still thinking about how this should interact with behavior composition e.g.Deletableand stuff.