Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse feedings without a duration #823

Merged
merged 1 commit into from
May 17, 2024

Conversation

MisterPhilip
Copy link
Contributor

Fix for #817

Collapses feedings with 0 duration into one entry on the timeline.
image

Side note: preference on line endings (\n or \r\n)? It's seemingly mixed throughout the repo, but I can force either way in my editor.

@coveralls
Copy link

Coverage Status

coverage: 98.617% (-0.04%) from 98.652%
when pulling e18b07b on MisterPhilip:817_collapse_feedings_timeline
into 77c227a on babybuddy:master.

@cdubz
Copy link
Member

cdubz commented May 13, 2024

Side note: preference on line endings (\n or \r\n)? It's seemingly mixed throughout the repo, but I can force either way in my editor.

Huh I don't think I realized this wasn't already normalized hah. I'd prefer we use \n and figure out some way to enforce that...

@cdubz cdubz merged commit 153fa24 into babybuddy:master May 17, 2024
12 checks passed
@cdubz cdubz added the enhancement Feature requests or improvements to existing functionality label May 17, 2024
@cdubz cdubz added this to the 2.5.0 milestone May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants