New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forms for managing tags #809
Conversation
Thanks for working on this! I’m traveling this weekend but will take a look next week. Curious to see what you found developing from Windows. Baby Buddy has a pretty outdated dev env and build system. I’ve been very slowly trying to bring it up to date but it’s still relying on some long abandoned tooling hah. |
Yeah, I'm still tweaking and jotting down notes. I'll eventually split this out into it's own conversation, but for reference with this PR, I've had to:
Anyways, I suspect this will be ready for final review sometime next week. The core features are all there, just aiming to complete the stretch goals. @cdubz - I could use your feedback on the last stretch goal (" Show all items (TBD if in a single view or in separate tables) that are tagged with this tag"). My idea here is to show everything that is tagged with a given tag. An example where this could be useful is we tag our measurements with "home measurement" or "office measurement", depending on if the measurement was taken at home or the doctor's office. Being able to see all measurements for "office measurement" would give us a quick overview into his official vitals. From the UX side though, I'm not sure if there is a good way to unify everything in a single table. Measurements could probably be rolled into a single table, but then the activities have too many different attributes that might need to be displayed in a single table. We could show a table for all measurements and one for each activity too, but I'm not sure how much easier that would be to parse from the user's perspective. Maybe this would be more useful just as a separate feature with a measurements overview page that could filter down instead of doing it via a tag detail view? Anyways, this would be the desired output for a given tag:
|
Yeah the UI here would be pretty challenging. I think we'd have to show a very limited amount of information about each tag thing and link off to the main entry for more detail. Maybe the timeline page can offer some basic insight? I don't think we would necessarily want to use that format but it does deal with presenting information about all the separate models together. |
@MisterPhilip is this one ready for review yet? We still have it marked draft but I'm happy to start taking a closer look when you're ready. |
Changes the empty filler in the sleep pattern report to instead be awake time. Add labels to this awake time so it is possible to see for how long the baby was awake between sleeps.
@cdubz - Sorry, was pulled onto a different project recently. I have one more test to fix and then I should be set. I think I'll be able to wrap it up this weekend. |
@cdubz all yours for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MisterPhilip thanks so much for your work here -- this is awesome! Let me see if I can get the rebase conflicts resolved...
Yeah, sorry about that! I had rebased, but I think had selected mine fork instead of the main babybuddy as the origin. |
Yeah no worries I just squashed it 😁 |
Looks lovely @MisterPhilip ! |
Closes #460, adding support for a UI for managing tags.
Goals for this PR:
Add a preview tag feature in the form that automatically updates when the color is updatedShow all items (TBD if in a single view or in separate tables) that are tagged with this tagAdded a new menu item:
The tag list view, with preview of the color:
The tag detail view, with links to the measurements & activities, pre-filtered to the current filter
The tag edit form with default browser color editor:
The tag deletion confirmation warning:
Other notes - I might be one of the few developing on Windows. I had a few issues with the build scripts and getting the correct line endings to show. What is committed is a much smaller amount than what was coming out prior to editing the build scripts/configs. I have these changes locally but might be worth discussing if they should be merged in (separately) to the repo. Also, I'm not as familiar with Django/Python, so definitely happy to hear any feedback you may have. I figured this would be a good first PR that had some substance 😄