Add long sms concat info for received sms #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `concat` property for received sms //get Concantion from pdu `smsDict['udh']`
Add `concat` property for `ReceivedSms`: - Get Concantion from pdu `smsDict['udh']` - Update examples/sms_handler_demo.py
babca
reviewed
Mar 12, 2019
| @@ -18,7 +18,9 @@ | |||
| from gsmmodem.modem import GsmModem | |||
|
|
|||
| def handleSms(sms): | |||
| print(u'== SMS message received ==\nFrom: {0}\nTime: {1}\nMessage:\n{2}\n'.format(sms.number, sms.time, sms.text)) | |||
| # long sms Concatenation support: reference, parts, number | |||
| concat = sms.concat.__dict__ if sms.concat else {} | |||
There was a problem hiding this comment.
Is it necessary to have this line here?
Could you move this logic to the module?
Just thinking.
There was a problem hiding this comment.
this process just for print purpose,
in GsmModem, the sms.concat property will be:
- dict (for long sms)
- None (for normal sms)
I think None is more clear than {} for normal sms 's concat info,
what do you think about it?
|
There is a small conflict to resolve. Do you feel you can resolve it? (I'm sure you can, the conflicts seem pretty self-explanatory.) |
lcnittl
reviewed
Nov 2, 2021
There was a problem hiding this comment.
Thank you for your additions!
I have now resolved the merge conflict - if you please could confirm, @yurenchen000, that those changes reflect your proposal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COPY from faucamp#93
Add
concatproperty forReceivedSms:smsDict['udh']examples/sms_handler_demo.pytest output of sms_handler_demo.py