SO-4280: Enforce new rules to determine definition status of a concept #663
Conversation
AAAlinaaa
commented
Sep 17, 2020
AAAlinaaa
commented
- If a concept only has equivalent class axioms make it defined
- If a concept only has sub class axioms make it primitive
- If a concept contains a mixture make it primitive as well
* If a concept only has equivalent class axioms make it defined * If a concept only has sub class axioms make it primitive * If a concept contains a mixture make it primitive as well
There was a problem hiding this comment.
Please re-formulate the expression so that the definition status only becomes FULLY_DEFINED if - ignoring any GCI axioms - all remaining axioms are of type "equivalent classes". 0 axioms of such kind should still result in PRIMITIVE status, which doesn't happen with the code in its current form.
| @@ -35,7 +35,7 @@ public static String getDefinitionStatusFromExpressions(Set<String> owlExpressio | |||
|
|
|||
| return owlExpressions.stream() | |||
| .filter(expression -> !Strings.isNullOrEmpty(expression)) | |||
There was a problem hiding this comment.
Filter GCI axioms here (in class SnomedOWLAxiomHelper), not in the create or update requests. They don't have a say in the concept's suggested definition status, but should be going through when creating or updating a SNOMED CT concept, just as before.
Or did they cause some other problem?
|
Putting this to on hold. Not sure about the proper logic here, need more information to decide. |
cmark
changed the title
