Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Node.js to version 18 #2753

Merged
merged 2 commits into from Sep 27, 2023
Merged

Conversation

lechnerc77
Copy link
Contributor

@lechnerc77 lechnerc77 commented Sep 16, 2023

The current Node.js based templates are building on Node.js 16. This version has reached its end of life on 2023-09-11 (https://nodejs.dev/en/about/releases/). There are aslo some inconsistencies as the App service ToDo app already ran on Node.js 18

This PR contains the update of the files using the outdated Node.js version to the current LTS version Node.js 18.

Remark
I tested the dev conatiner setup the build of the Docker Image and the fucntional correctness of the App service app after the update including a full deploy. However I might have missed some sceanrios and cases, so I assume there is a build pipeline that could be run to check that the overall setup is still healthy.

@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution lechnerc77! We will review the pull request and get back to you soon.

Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the fix, @lechnerc77!

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: azd-starter-terraform

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-terraform -b pr/2753

View Changes | Compare Changes


Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/2753

View Changes | Compare Changes


Project: todo-csharp-sql-swa-func

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/2753

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/2753

View Changes | Compare Changes


Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/2753

View Changes | Compare Changes


Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/2753

View Changes | Compare Changes


Project: todo-java-postgresql-terraform

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/2753

View Changes | Compare Changes


Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/2753

View Changes | Compare Changes


Project: todo-nodejs-mongo-aks

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/2753

View Changes | Compare Changes


Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/2753

View Changes | Compare Changes


Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/2753

View Changes | Compare Changes


Project: todo-nodejs-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/2753

View Changes | Compare Changes


Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/2753

View Changes | Compare Changes


Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/2753

View Changes | Compare Changes


Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/2753

View Changes | Compare Changes


Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/2753

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/2753

View Changes | Compare Changes


@vhvb1989 vhvb1989 merged commit 819cf29 into Azure:main Sep 27, 2023
27 checks passed
@lechnerc77 lechnerc77 deleted the chore-node-update branch October 22, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported identify a customer issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants