Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Node.js to version 18 #2753

Merged
merged 2 commits into from Sep 27, 2023
Merged

chore: update Node.js to version 18 #2753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc860f8
chore: update Node.js to version 18
lechnerc77 Sep 16, 2023
93b6183
Merge branch 'main' of github.com:Azure/azure-dev into chore-node-update
vhvb1989 Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/Dockerfile
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ RUN export DEBIAN_FRONTEND=noninteractive \
# az cli
&& curl -sSL https://aka.ms/InstallAzureCLIDeb | bash \
# nodejs
&& curl -fsSL https://deb.nodesource.com/setup_16.x | bash - \
&& curl -fsSL https://deb.nodesource.com/setup_18.x | bash - \
&& apt-get install -y nodejs \
# python
&& apt-get install -y --no-install-recommends python3-pip python-dev python3-venv \
Expand Down
2 changes: 1 addition & 1 deletion cli/azd/pkg/tools/npm/npm.go
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ func NewNpmCli(commandRunner exec.CommandRunner) NpmCli {
func (cli *npmCli) versionInfoNode() tools.VersionInfo {
return tools.VersionInfo{
MinimumVersion: semver.Version{
Major: 16,
Major: 18,
Minor: 0,
Patch: 0},
UpdateCommand: "Visit https://nodejs.org/en/ to upgrade",
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/aks/nodejs/devcontainer.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "Azure Developer CLI",
"image": "mcr.microsoft.com/devcontainers/javascript-node:16-bullseye",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/csharp/devcontainer.json
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
"ghcr.io/devcontainers/features/node:1": {
"version": "16",
"version": "18",
"nodeGypDependencies": false
},
"ghcr.io/azure/azure-dev/azd:latest": {}
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/csharp/func/devcontainer.json
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
"ghcr.io/devcontainers/features/node:1": {
"version": "16",
"version": "18",
"nodeGypDependencies": false
},
"ghcr.io/azure/azure-dev/azd:latest": {}
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/nodejs/devcontainer.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "Azure Developer CLI",
"image": "mcr.microsoft.com/devcontainers/javascript-node:16-bullseye",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
"features": {
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/nodejs/func/devcontainer.json
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@
"build": {
"dockerfile": "Dockerfile",
"args": {
"IMAGE": "javascript-node:16-bullseye"
"IMAGE": "javascript-node:18-bullseye"
}
},
"features": {
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/nodejs/terraform/devcontainer.json
View file
Open in desktop
@@ -1,6 +1,6 @@
{
"name": "Azure Developer CLI",
"image": "mcr.microsoft.com/devcontainers/javascript-node:16-bullseye",
"image": "mcr.microsoft.com/devcontainers/javascript-node:18-bullseye",
"features": {
"ghcr.io/devcontainers/features/azure-cli:1": {
},
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/python/devcontainer.json
View file
Open in desktop
Expand Up @@ -5,7 +5,7 @@
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
"ghcr.io/devcontainers/features/node:1": {
"version": "16",
"version": "18",
"nodeGypDependencies": false
},
"ghcr.io/azure/azure-dev/azd:latest": {}
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/python/func/devcontainer.json
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
"ghcr.io/devcontainers/features/node:1": {
"version": "16",
"version": "18",
"nodeGypDependencies": false
},
"ghcr.io/azure/azure-dev/azd:latest": {}
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.devcontainer/devcontainer.json/python/terraform/devcontainer.json
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@
"ghcr.io/devcontainers/features/docker-in-docker:2": {
},
"ghcr.io/devcontainers/features/node:1": {
"version": "16",
"version": "18",
"nodeGypDependencies": false
},
"ghcr.io/devcontainers/features/terraform:1": {
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.github/workflows/java/terraform/azure-dev.yml
View file
Open in desktop
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Install Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Login az
uses: azure/login@v1
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.github/workflows/nodejs/bicep/azure-dev.yml
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Log in with Azure (Federated Credentials)
if: ${{ env.AZURE_CLIENT_ID != '' }}
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.github/workflows/nodejs/func/azure-dev.yml
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Install Azure Function Core Tools
run: |
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.github/workflows/nodejs/terraform/azure-dev.yml
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Login az
uses: azure/login@v1
Expand Down
2 changes: 1 addition & 1 deletion templates/common/.github/workflows/terraform/azure-dev.yml
View file
Open in desktop
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install Nodejs
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18

- name: Login az
uses: azure/login@v1
Expand Down
2 changes: 1 addition & 1 deletion ...es/common/infra/terraform/core/host/appservice/appservicenode/appservicenode_variables.tf
View file
Open in desktop
Expand Up @@ -47,7 +47,7 @@ variable "resource_token" {
variable "node_version" {
description = "the application stack node version to set for the app service."
type = string
default = "16-lts"
default = "18-lts"
}

variable "always_on" {
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/api/js/Dockerfile
View file
Open in desktop
@@ -1,4 +1,4 @@
FROM node:16.13-alpine AS build
FROM node:18.17-alpine AS build

WORKDIR /app

Expand Down
4 changes: 2 additions & 2 deletions templates/todo/api/js/README.md
View file
Open in desktop
Expand Up @@ -4,8 +4,8 @@

### Prerequisites

- Node (16.13.0)
- NPM (8.1.0)
- Node (18.17.1)
- NPM (9.8.1)

### Local Environment

Expand Down
2 changes: 1 addition & 1 deletion templates/todo/common/infra/bicep/app/api-functions-node.bicep
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ module api '../../../../../common/infra/bicep/core/host/functions.bicep' = {
appServicePlanId: appServicePlanId
keyVaultName: keyVaultName
runtimeName: 'node'
runtimeVersion: '16'
runtimeVersion: '18'
storageAccountName: storageAccountName
}
}
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/csharp-cosmos-sql/README.md
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [.NET SDK 6.0](https://dotnet.microsoft.com/download/dotnet/6.0) - for the API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-csharp) with this template (`Azure-Samples/todo-csharp-cosmos-sql`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/csharp-sql-swa-func/README.md
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ The following prerequisites are required to use this application. Please ensure
- [Azure Developer CLI](https://aka.ms/azd-install)
- [.NET SDK 6.0](https://dotnet.microsoft.com/download/dotnet/6.0) - for the API backend
- [Azure Functions Core Tools (4+)](https://docs.microsoft.com/azure/azure-functions/functions-run-local)
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-csharp) with this template(`Azure-Samples/todo-csharp-sql-swa-func`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/csharp-sql/README.md
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [.NET SDK 6.0](https://dotnet.microsoft.com/download/dotnet/6.0) - for the API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-csharp) with this template (`Azure-Samples/todo-csharp-sql`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/java-mongo-aca/README.md
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Java 17 or later](https://learn.microsoft.com/en-us/java/openjdk/install) - for API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend
- [Docker](https://docs.docker.com/get-docker/)

### Quickstart
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/java-mongo/README.md
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Java 17 or later](https://learn.microsoft.com/en-us/java/openjdk/install) - for API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-java) with this template(`Azure-Samples/todo-java-mongo`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/java-postgresql/README.md
View file
Open in desktop
Expand Up @@ -17,7 +17,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Java 17 or later](https://jdk.java.net/) - for API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for Web frontend
- [Terraform](https://www.terraform.io/)
- Requires the [Azure CLI](https://learn.microsoft.com/cli/azure/install-azure-cli)

Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/nodejs-mongo-aca/README.md
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ Let's jump in and get this up and running in Azure. When you are finished, you w
The following prerequisites are required to use this application. Please ensure that you have them all installed locally.

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Docker](https://docs.docker.com/get-docker/)

### Quickstart
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/nodejs-mongo-aks/README.md
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ Let's jump in and get this up and running in Azure. When you are finished, you w
The following prerequisites are required to use this application. Please ensure that you have them all installed locally.

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Kubernetes CLI (kubectl)](https://kubernetes.io/docs/tasks/tools/)

### Quickstart
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/nodejs-mongo-swa-func/README.md
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Azure Functions Core Tools (4+)](https://docs.microsoft.com/azure/azure-functions/functions-run-local)
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for API backend and Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-nodejs) with this template(`Azure-Samples/todo-nodejs-mongo-swa-func`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/nodejs-mongo/.repo/bicep/README.md
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ Let's jump in and get this up and running in Azure. When you are finished, you w
The following prerequisites are required to use this application. Please ensure that you have them all installed locally.

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for API backend and Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-nodejs) with this template(`Azure-Samples/todo-nodejs-mongo`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/nodejs-mongo/.repo/terraform/README.md
View file
Open in desktop
Expand Up @@ -37,7 +37,7 @@ Let's jump in and get this up and running in Azure. When you are finished, you w
The following prerequisites are required to use this application. Please ensure that you have them all installed locally.

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for API backend and Web frontend
- [Terraform CLI](https://aka.ms/azure-dev/terraform-install)
- Requires the [Azure CLI](https://learn.microsoft.com/cli/azure/install-azure-cli)

Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/python-mongo-aca/README.md
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Python (3.8+)](https://www.python.org/downloads/) - for the API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend
- [Docker](https://docs.docker.com/get-docker/)

### Quickstart
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/python-mongo/.repo/bicep/README.md
View file
Open in desktop
Expand Up @@ -38,7 +38,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Python (3.10+)](https://www.python.org/downloads/) - for the API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend

### Quickstart
To learn how to get started with any template, follow the steps in [this quickstart](https://learn.microsoft.com/azure/developer/azure-developer-cli/get-started?tabs=localinstall&pivots=programming-language-python) with this template(`Azure-Samples/todo-python-mongo`).
Expand Down
2 changes: 1 addition & 1 deletion templates/todo/projects/python-mongo/.repo/terraform/README.md
View file
Open in desktop
Expand Up @@ -39,7 +39,7 @@ The following prerequisites are required to use this application. Please ensure

- [Azure Developer CLI](https://aka.ms/azd-install)
- [Python (3.8+)](https://www.python.org/downloads/) - for the API backend
- [Node.js with npm (16.13.1+)](https://nodejs.org/) - for the Web frontend
- [Node.js with npm (18.17.1+)](https://nodejs.org/) - for the Web frontend
- [Terraform CLI](https://aka.ms/azure-dev/terraform-install)
- Requires the [Azure CLI](https://learn.microsoft.com/cli/azure/install-azure-cli)

Expand Down