Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emerald Dragons no longer have 0% health events #18893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Emerald Dragons no longer have 0% health events #18893

wants to merge 1 commit into from

Conversation

Day36512
Copy link

Events happen at 75, 50 or 25 percent health and should not include a 0% event.

Changes Proposed:

This PR proposes changes to:

  • Scripts (bosses, spell scripts, creature scripts).

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)

Video showing Dot event does not happen at 0% as an example:
https://youtu.be/Wos1qtt280g?si=U6Kif8SeUgVI51lR

Tests Performed:

This PR has been:

  • Tested in-game by the author.

@Day36512
Emerald Dragons no longer have 0% health events
5a1a5ad 
Events happen at 75, 50 or 25 percent health and should not include 0%.
@github-actions github-actions bot added CORE Related to the core Script file-cpp Used to trigger the matrix build labels May 13, 2024
@elthehablo
Copy link
Contributor

Might as well change the script to use ScheduleHealthCheckEvent. It's the more modern and preferred approach. It can be called on reset

elthehablo
elthehablo requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@elthehablo elthehablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ScheduleHealthCheckEvent

@elthehablo
Copy link
Contributor

Actually I 100% forgot this is not BossAI and cannot be and I don't think it is implemented for ScriptedAI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elthehablo elthehablo elthehablo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Day36512 @elthehablo