WIP: Multithreading #92
Open
+2,867
−2,480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed all references to the global
Ayathread and passed execution context down using the refactored blocks from this PR. With a bit more refactoring I was able to provide an API to spawn and manage multiple instances theAyathread (now calledAyaThread).The API is very clunky and there are a handful of bugs I still need to work through but the implementation is quite stable now.
Examples
I used the raytracer implementation to test stability and performance since it was a fairly large aya project. I implemented a thread pool using the current version of the thread API. It is a bit clunky and needs some improvement but was very stable overall.
The performance is significantly better with more threads but there is still quite a bit of overhead. Rendering an image with 15 threads gave a ~6x speedup as seen below:
15 threads, execution time ~3s
1 thread, execution time ~18s
Code for the multithreaded renderer is here: https://github.com/nick-paul/aya-raytrace/tree/thread