Improve GLSP UI Extension mechanism for easier re-use of HTML elements #516
Conversation
| inset: 0; | ||
| width: 100%; | ||
| height: 48px; | ||
| background: var(--glsp-tool-bar-bg); | ||
| box-shadow: var(--glsp-box-shadow); | ||
| z-index: 10; | ||
| container: toolbar / inline-size; |
There was a problem hiding this comment.
why remove this?
without the container query at the bottom of this file will no longer work I think...
There was a problem hiding this comment.
Good point! I think I may have committed that by mistake. I'll push an update as soon as the other change is merged cause I'll need to rebase anyway, thank you!
martin-fleck-at
force-pushed
the
features/ui-extensions
branch
from
4af96b4
to
fbc7b51
Compare
|
@ivy-lli I pushed an update that should fix the issue and align the HTML structure and layout styles across ALL integrations (standalone, viewer, Eclipse -- I could test standalone and viewer but not Eclipse). Could you please have another look? I also fixed the issue we saw with the moving of an element even though it wasn't being dragged. |
I will quickly test the eclipse integration and check the copy paste bug. |
|
started the build pipelines |
|
the process dom node no longer has the id=sprotty: To test the eclipse integration:
|
|
The move bug seems to be solved, thanks for that 👍 |
|
Quickly tried to reproduce the copy+paste problem:
|
Dang, will fix in a minute. |
|
and a lot of failing tests :) |
martin-fleck-at
force-pushed
the
features/ui-extensions
branch
3 times, most recently
from
daf2b31
to
fb40d45
Compare
|
@ivy-lli I fixed the Eclipse issue and the regular tests failing, now I'm working on the web tests but for some reason Playwright generates gigabytes of temporary data so it is a bit harder to investigate. Hope to push an update soon! |
martin-fleck-at
force-pushed
the
features/ui-extensions
branch
from
fb40d45
to
f71c6fb
Compare
|
@ivy-lli Could you please re-trigger the CI? |
- Allow more fine-grained definition of container and parent - Allow more fine-grained definition of container within parent - Replace hard-coded styles with 'hidden' class - Rework index file to define structure and use grid for layouting - Properly align ALL index files with same structure, loading and style - Remove workaround for toolbar height (48px adjustment) - Ensure Quick Action UI is still rendering correctly Minor fix: - Ensure that mouse move is only ever executed on drag
martin-fleck-at
force-pushed
the
features/ui-extensions
branch
from
f71c6fb
to
f7c382f
Compare
|
@ivy-lli Ok it was one test that I fixed wrongly because it behaves differently locally but I'm hopeful that the next test run should go through. Could I ask for one more trigger? |
|
@ivy-lli Finally :D |
|
@ivy-lli Thank you for your patience! I'll push an update to the VS Code extension in the next 2-3 hours :-) |
Minor fix: