Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config for ignoring absolute URLs (#5902) #6192

Open
wants to merge 24 commits into
base: v1.x
Choose a base branch
from

Conversation

GethosTheWalrus
Copy link

@GethosTheWalrus GethosTheWalrus commented Jan 18, 2024

feat: Add a configuration option allowing developers to specify whether or not absolute URLs should take precedence over base URLs.

fixes #5902

prevent request URL from overriding preconfigured base URL

BREAKING CHANGE: code relying on the above will now combine the URLs instead of prefer request URL
@GethosTheWalrus GethosTheWalrus marked this pull request as draft January 18, 2024 17:01
@GethosTheWalrus GethosTheWalrus marked this pull request as ready for review January 18, 2024 19:30
@mrosenbaum15
Copy link

@GethosTheWalrus really feel like I could use this👌

@GethosTheWalrus GethosTheWalrus changed the title fix: prevent request url override feat: Add a configuration option allowing developers to specify whether or not absolute URLs should take precedence over base URLs Jan 22, 2024
@GethosTheWalrus GethosTheWalrus changed the title feat: Add a configuration option allowing developers to specify whether or not absolute URLs should take precedence over base URLs feat: Add config for ignoring absolute URLs (#5902) Jan 22, 2024
@GethosTheWalrus
Copy link
Author

@jasonsaayman any chance I could get a review on this one 😉 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseURL config vs absolute URL
3 participants