New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add config for ignoring absolute URLs (#5902) #6192
Open
GethosTheWalrus
wants to merge
24
commits into
axios:v1.x
Choose a base branch
from
GethosTheWalrus:issue5902-base-url-vs-absolute
base: v1.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add config for ignoring absolute URLs (#5902) #6192
GethosTheWalrus
wants to merge
24
commits into
axios:v1.x
from
GethosTheWalrus:issue5902-base-url-vs-absolute
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prevent request URL from overriding preconfigured base URL BREAKING CHANGE: code relying on the above will now combine the URLs instead of prefer request URL
@GethosTheWalrus really feel like I could use this👌 |
GethosTheWalrus
changed the title
fix: prevent request url override
feat: Add a configuration option allowing developers to specify whether or not absolute URLs should take precedence over base URLs
Jan 22, 2024
GethosTheWalrus
changed the title
feat: Add a configuration option allowing developers to specify whether or not absolute URLs should take precedence over base URLs
feat: Add config for ignoring absolute URLs (#5902)
Jan 22, 2024
@jasonsaayman any chance I could get a review on this one 😉 ? |
… error when baseUrl undefined
…Walrus/axios into issue5902-base-url-vs-absolute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add a configuration option allowing developers to specify whether or not absolute URLs should take precedence over base URLs.
fixes #5902