Fix the issue that duplicate AUDs are added and can't be played normally in MacOS. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… And the output HLS stream or the ts files can't be played normal in Safari/QuickTime player. (the frame display becomes incorrect.) [Why] The size of AUD in the sample are 3 and "nalu_size != 2" is always true, so AUDs are added. [How] Remove the nalu_size checking and only check unit type.
|
According to the AVC spec, AccessUnit delimiter NAL units are always 2 bytes long. Can you share an example stream where you have AUD NAL units that are not 2 bytes long? |
|
The stream is transcoded and output by using Edius. I transcoded 15 sec. video (bbb_720p.mp4) from Big Buck Bunny. Using the file as the input for mp42hls will reproduce the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[What] Fix the issue that duplicate AUDs are added when the input H.264 already has AUD. And the output HLS stream or the ts files can't be played normally in Safari/QuickTime player. (the frame display order becomes incorrect.)
[Why] The size of AUD in the samples are 3 and "nalu_size != 2" is always true, so AUDs are added.
[How] Remove the nalu_size checking and only check unit type.