Various MP4Decrypt fixes #420
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MythodeaLoL
approved these changes
Feb 19, 2020
|
@barbibulle can u update this? thank u man. |
barbibulle
reviewed
Feb 29, 2020
| } | ||
| if (tenc != NULL) { | ||
| const AP4_DataBuffer* key = m_KeyMap->GetKeyByKid(tenc->GetDefaultKid()); | ||
| if (key != NULL) m_KeyMap->SetKey(trak->GetId(), key->GetData(), 16); |
There was a problem hiding this comment.
Writing to the key map from AP4_CencDecryptingProcessor breaks the constness of that map. It doesn't seem right. Can you explain why you need to write a key here?
There was a problem hiding this comment.
mp4decrypt couldn't properly handle selecting the track based on key ID, it only seemed to work by track ID.
|
Any update on progress bar? |
|
Yes, please add this. It's been so long... |
|
This modified version has a progress bar: https://github.com/NanDesuKa-FR/mp4decrypt_mod_linux |
|
Any update on progress bar? |
|
@FugerZuer link is dead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed MP4Decrypt so it can:
Fixes #368