-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Construct): replace custom resource with bedrock L1 constructs #414
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 93.29% 93.07% -0.22%
==========================================
Files 50 47 -3
Lines 11420 11164 -256
Branches 255 358 +103
==========================================
- Hits 10654 10391 -263
- Misses 766 773 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Signed-off-by: github-actions <github-actions@github.com>
Tested in TS, deployment of agents with KBs using OSS and Pinecone works as expected Remaining tasks:
This issue is not related to the changes from this branch, and seems to happen on MacOS only. Will open a separate ticket for it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- delete the file under 'public-registries'
- couple of commented tests which should be fixed
otherwise should be good !
Signed-off-by: github-actions <github-actions@github.com>
Fixes #361
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.