refactor: reduce clone usage #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoneDot
force-pushed
the
change-context-to-mutable-borrow
branch
3 times, most recently
from
b6d3b9d
to
b5493c9
Compare
StoneDot
changed the title
StoneDot
force-pushed
the
change-context-to-mutable-borrow
branch
from
b5493c9
to
2299ba5
Compare
StoneDot
force-pushed
the
change-context-to-mutable-borrow
branch
from
2299ba5
to
f5189ab
Compare
StoneDot
changed the title
StoneDot
force-pushed
the
change-context-to-mutable-borrow
branch
from
f5189ab
to
1ff3edc
Compare
StoneDot
force-pushed
the
change-context-to-mutable-borrow
branch
from
1ff3edc
to
4861258
Compare
Signed-off-by: Hiroaki Goto <hiroag@amazon.com>
ryota-sakamoto
force-pushed
the
change-context-to-mutable-borrow
branch
from
4861258
to
0b1de00
Compare
ryota-sakamoto
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
This PR is related to #6.
Description of changes:
This PR reduces the use of
clone.There are primary and accompanying goals such as:
cloneto improve performance.I welcome the discussion to achieve the above goals.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.