Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration tests for import #230

Merged
merged 1 commit into from
May 17, 2024

Conversation

StoneDot
Copy link
Contributor

Issue #, if available:
#143

Description of changes:
This pull request adds integration tests for import command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@StoneDot StoneDot requested a review from a team as a code owner May 15, 2024 02:43
@StoneDot StoneDot added the test Something related to test label May 15, 2024
@StoneDot StoneDot mentioned this pull request May 15, 2024
23 tasks
@ryota-sakamoto
Copy link
Contributor

Would you add test for --enable-set-inference?

dynein/src/cmd.rs

Lines 386 to 388 in f24d513

/// Enable type inference for set types. This option is provided for backward compatibility.
#[structopt(long)]
enable_set_inference: bool,

Signed-off-by: Hiroaki Goto <hiroag@amazon.com>
@StoneDot
Copy link
Contributor Author

@ryota-sakamoto Thank you for pointing it out. I have added a test for --enable-set-inference. Could you please check it?

@ryota-sakamoto ryota-sakamoto merged commit f043ce5 into awslabs:main May 17, 2024
4 of 5 checks passed
@StoneDot StoneDot deleted the add-test-for-import branch May 17, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Something related to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants